langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Update poetry lock to allow SQLAlchemy v2

Open baron opened this issue 1 year ago • 8 comments

It seems that #1578 adds support for SQLAlchemy v2 but the poetry lock file is still at 1.4.46.

baron avatar Mar 19 '23 01:03 baron

It seems that jupyter-cache is another blocking dependency:

jupyter-cache https://github.com/hwchase17/langchain/blob/master/poetry.lock#L2526 https://github.com/executablebooks/jupyter-cache/issues/92 https://github.com/executablebooks/jupyter-cache/pull/93

This dependency was introduced in pull request #534 but jupyter_cache doesn't seem to be called anywhere in the code base when you do grep -r "jupyter_cache" . in the root directory of the project.

baron avatar Mar 19 '23 04:03 baron

jupyter_cache is a dependency for myst-nb which is used in creating the docs. I do have a PR open with jupyter-cache to allow SQLAlchemy 2.

jzluo avatar Mar 19 '23 17:03 jzluo

Thanks for the clarification and your efforts. Added some reactions and a "+1".

baron avatar Mar 19 '23 23:03 baron

jupyter-cache hasn't been maintained for more than 9 months, should we start looking for alternatives? Being blocked from SQLAlchemy 2.0 is pretty painful.

winstxnhdw avatar Apr 13 '23 16:04 winstxnhdw

Should we add SALAlchemy as an optional dependency?

elonzh avatar Apr 14 '23 11:04 elonzh

Should we add SALAlchemy as an optional dependency?

@elonzh Please add SALAlchemy 2.0.

ryugonomura avatar Apr 17 '23 09:04 ryugonomura

@hwchase17 Please any update on this? Can I open a PR to fix this?

KennyRich avatar Apr 20 '23 16:04 KennyRich

@jzluo Can we mark myst-nb as optional dependency? SQLAlchemy is such an important library for many data projects and being blocked because of rarely used feature is big pain.

vnktsh avatar Apr 23 '23 01:04 vnktsh