chat-langchain icon indicating copy to clipboard operation
chat-langchain copied to clipboard

Fix for recent breaking changes

Open gadkins opened this issue 1 year ago • 2 comments

This PR fixes two breaking changes recently introduced in hwchase17/langchain:

  1. ConversationalRetrievalChain replacing ChatVectorDBChain per this blog
  2. AsyncCallbackManager moved to langchain.callbacks.manager after this refactor

gadkins avatar May 03 '23 04:05 gadkins

@gadkins just tried your fix. I think you also need the change from this branch of yours: https://github.com/hwchase17/chat-langchain/compare/master...gadkins:chat-langchain:upgade-to-converstaionalretrievalchain

if I include that change on top of this branch it seems to work, thanks for figuring it out!

lefant avatar May 10 '23 14:05 lefant

It would be good to have this PR merged due to the package upgrade. Thanks! @hwchase17

jpzhangvincent avatar May 11 '23 22:05 jpzhangvincent