landroni

Results 69 comments of landroni

I think this one is more related to #50.

I double-checked and I can replicate it here (on Linux) : ``` > sessionInfo() R version 3.0.2 (2013-09-25) Platform: x86_64-pc-linux-gnu (64-bit) locale: [1] LC_CTYPE=en_US.UTF-8 LC_NUMERIC=C LC_TIME=en_US.UTF-8 [4] LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8...

I'm also getting this when using gdf() purely as a viewer, e.g.: ``` sapply(1:ncol(X), function(j) editable(d, j)

I did some rudimentary profiling with RStudio, and here are there results: ![screenshot_2016-05-07_06-44-29](https://cloud.githubusercontent.com/assets/1318567/15090223/93958810-141f-11e6-8f1c-a569e27c909b.png) There seem to be a lot of calls (too many?) in some parts of the code, which...

If I look more closely into the calls: ![screenshot_2016-05-07_06-56-48](https://cloud.githubusercontent.com/assets/1318567/15090234/f45025f6-1420-11e6-846f-c96f6bd00dcd.png) I can pinpoint several potential suspects: `.getAutoMethodByName`, `get_view_column`, and a number of `try` calls...

Is there perhaps some _additional_ formatting going on for `Date` columns? Maybe it can be optionally turned off somehow...

Instead of formatting things per-cell, would one option be to do what we do for `logical` vectors and have a function that transparently transforms `Date` to `character` in the df...

Thanks! Will check out over the weekend and report back.

Performance is much better! I tried it on my real data frame, which are big and contain `Date` variables, and I no longer see the slowness issues as before. (I...

As a first batch of files, I would suggest to include some from Geany's source code. Some candidates: https://github.com/geany/geany/blob/master/src/filetypes.c https://github.com/geany/geany/blob/master/scripts/create_py_tags.py https://github.com/geany/geany/blob/master/scripts/changelist.pl