drupal
drupal copied to clipboard
lando/lando#3744: Check to make sure default url isn't being overridden in proxy settings.
Bare minimum self-checks
What do you think of a person who only does the bare minimum?
- [ ] I've updated this PR with the latest code from
main - [ ] I've done a cursory QA pass of my code locally
- [ ] I've ensured all automated status check and tests pass
- [ ] I've connected this PR to an issue
Pieces of flare
- [ ] I've written a unit or functional test for my code
- [ ] I've updated relevant documentation it my code changes it
- [ ] I've updated this repo's README if my code changes it
- [ ] I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)
Finally
- [ ] I've requested a review with relevant people
If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!
You can also check out the coder guide.
Deploy Preview for lando-drupal ready!
| Name | Link |
|---|---|
| Latest commit | 109d56ccaa7ca7a67d755df1e98b54b645804892 |
| Latest deploy log | https://app.netlify.com/sites/lando-drupal/deploys/6706e6c61bd4ff0008c8519a |
| Deploy Preview | https://deploy-preview-136--lando-drupal.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 92 (🔴 down 5 from production) Accessibility: 96 (no change from production) Best Practices: 100 (no change from production) SEO: 93 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
FWIW i think we want to look for issues in the logic over hereish https://github.com/lando/core/blob/main/plugins/proxy/app.js#L131
