Martin Landa
Martin Landa
I tested this PR by creating `include/VERSION_GIT` and than removing `.git` directory (which is not located in tarball): ``` checking for include/VERSION_GIT... yes fatal: not a git repository (or any...
@HuidaeCho Are you planning to merge this PR?
> Thank for review and suggestions. Both issues are fixed with commit no. Great, I tested updated PR and I can confirm that both issues are fixed.
@tmszi Small note: It make sense to me to show the dialog for selecting location to be downloaded when process of downloading is aborted. I am just not sure whether...
When testing multiple times I am getting error: ``` Traceback (most recent call last): File "/home/martin/src/grass/dist.x86_64-pc-linux- gnu/gui/wxpython/core/gthread.py", line 138, in OnDone event.ondone(event) File "/home/martin/src/grass/dist.x86_64-pc-linux- gnu/gui/wxpython/startup/locdownload.py", line 411, in download_complete_callback self.parent.newLocationIsDownloaded.emit()...
> I wasn't successfull to reproduce it. I tested again with the same result:  @tmszi It seems to be related to multiple GRASS data dirs (databases). I tried to...
I was not able to reproduce this bug in the `main` branch. So it seems to be related to this PR.
Both PR which are related to this issue haven't been backported to 8.3. Changing milestone to 8.4.0.
@ninsbl Can we close this issue?
@wenzeslaus Still relevant?