Marc Lanctot
Marc Lanctot
Removing the pytype hints should be enough. Change: ``` def _update_param_grid_rows(self, grid: Gtk.Grid, params: Dict[str, pyspiel.GameParameter]): ``` to ``` def _update_param_grid_rows(self, grid: Gtk.Grid, params): ``` or ``` def _update_param_grid_rows(self, grid:...
> Thanks for the quick response! The same issue was opened over a year ago on their end: [michalsustr/spielviz#3](https://github.com/michalsustr/spielviz/issues/3). Spielviz seems somewhat dead though, but I don't have a good...
> > Thanks for the quick response! The same issue was opened over a year ago on their end: [michalsustr/spielviz#3](https://github.com/michalsustr/spielviz/issues/3). Spielviz seems somewhat dead though, but I don't have a...
I think longer term someone should either takeover SpielViz maintenance or make a new visualization tool. I would be quite happy with a new one that is not licensed under...
I didn't really have a suggestion.. I would have to dig into the code to understand things better first. It's been a while since I looked at that. But I...
@tacertain Actually, I guess I did have a suggestion, sorry. I think you're saying that we now use python native types for the game parameters, and if so.. I agree...
> Removing the type hint did help it, but `is_mandatory()` is called on it, which is missing (line 94 of the same file): > > ```python > label.set_text(f"{name}*" if default_param.is_mandatory()...
Awesome progress, thanks! It would be great if one of you submitted a PR to SpielViz to fix it. I would then happily volunteer to send @michalsustr one email per...
Yeah, I am just not sure if it fixes it without trying it out, and won't be able to until Monday. Is it easy for you to try it? If...
Good point, yeah we'll need to support Python 3.9. I'll take a crack at it and worst case we just leave the fix entirely to the SpielViz side.