Marc Lanctot

Results 167 comments of Marc Lanctot

Hi @huynq55, Great! The best place to start is the "Adding a game" section of the developer guide: https://github.com/deepmind/open_spiel/blob/master/docs/developer_guide.md The files will be found if they are added to the...

Very nice, thanks @Jazeem !! I'm on vacation at the moment but will take a look when I'm back next week.

Hi @Jazeem, Hmm.. MCTS performing similarly to random-- even for MCTS with random rollouts-- I'm surprised. I suspect a bug in the game implementation. How many simulations did MCTS have?...

Oh wait, depends on what you decided for the reward structure. If there are no intermediate rewards then I can see why it would be super hard for vanilla MCTS...

> Hi @steventrouble > > I was experimenting around the terminal condition and reward function. My initial assumption was that setting the game to end at 2048 might make it...

> Clone of https://github.com/gabrielecirulli/2048 Can you clarify how much of the code in here is based on this implementation? If you actually copied code from that repos, we likely have...

Hi @Jazeem, something changes on the MacOS behavior via GitHub Actions, can you apply these changes to trigger the tests again: https://github.com/deepmind/open_spiel/pull/907/files

Yeah it'll take more than just that one line, now there seems to be issues with the Jax versions .. :( Keep an eye on https://github.com/deepmind/open_spiel/pull/907, might only be resolved...

> > Keep an eye on #907, might only be resolved tomorrow. > > Sure. Will do 👍 Ok tests are passing, so you just need to update the Jax...

@Jazeem thanks, looking good! Are you done fixing things up for the moment? I've contacted @tewalds who will review the import, would be good to pull this one in now...