lance icon indicating copy to clipboard operation
lance copied to clipboard

chore: don't print warning if fp16 kernel not build

Open Xuanwo opened this issue 1 month ago • 5 comments

This PR will suppress the warning for fp16 kernel not being built

I personally think this warning isn't helpful, maybe we can just remove it?


This PR was primarily authored with Codex using GPT-5-Codex and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.

Xuanwo avatar Nov 25 '25 14:11 Xuanwo

I personally think this warning isn't helpful, maybe we can just remove it?

The purpose of the warning is to ensure that our production builds (which we deploy to real world workloads) have the correct features enabled.

Perhaps a better way to solve this same problem would be to add a features method which, at runtime, tells which features were compiled into the binary. This could then be used in a CI or pre/post-deploy smoke test of some kind to ensure that we are running builds in production that have all features builtin?

westonpace avatar Nov 25 '25 14:11 westonpace

Perhaps a better way to solve this same problem would be to add a features method which, at runtime, tells which features were compiled into the binary.

Seems nice to me. Are you expecting to add this features method and include a dedicated test for it in the smoke tests?

Xuanwo avatar Nov 25 '25 15:11 Xuanwo

Codecov Report

:x: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/lib.rs 0.00% 3 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Nov 27 '25 09:11 codecov[bot]

how can we know if fp16 kernel is supported after this?

BubbleCal avatar Dec 04 '25 10:12 BubbleCal

how can we know if fp16 kernel is supported after this?

check if fp16 included in pylance.enabled_features();

Xuanwo avatar Dec 04 '25 10:12 Xuanwo

Not that meaningful, let's just close.

Xuanwo avatar Jan 04 '26 10:01 Xuanwo