lance icon indicating copy to clipboard operation
lance copied to clipboard

test: added nested field testcase for field of type list of ints

Open nairajay2k opened this issue 2 years ago • 4 comments

test: added another create table method with a field as list of ints

nairajay2k avatar Feb 11 '24 13:02 nairajay2k

ACTION NEEDED

Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

github-actions[bot] avatar Feb 11 '24 13:02 github-actions[bot]

if you just want to check whether nested list of int works, that should already be covered in lance test cases. if the goal is to check scalar indices, i don't believe scalar indices are enabled for list columns (cc @westonpace). If you need to create an index, please feel free to open a feature request github issue for that.

thanks!

changhiskhan avatar Feb 11 '24 20:02 changhiskhan

https://github.com/lancedb/lancedb/discussions/899 has already been opened for this.

On Mon, Feb 12, 2024 at 1:44 AM Chang She @.***> wrote:

if you just want to check whether nested list of int works, that should already be covered in lance test cases. if the goal is to check scalar indices, i don't believe scalar indices are enabled for list columns (cc @westonpace https://github.com/westonpace). If you need to create an index, please feel free to open a feature request github issue for that.

thanks!

— Reply to this email directly, view it on GitHub https://github.com/lancedb/lance/pull/1939#issuecomment-1937857409, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJ6XWJ5N4INLF52QHQGBOELYTERC7AVCNFSM6AAAAABDDRJSOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHA2TONBQHE . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards Ajay 8762803277

nairajay2k avatar Feb 11 '24 22:02 nairajay2k

I think this is inspired by https://github.com/lancedb/lance/issues/1946, so I'm all for it

mkleinbort avatar Feb 16 '24 08:02 mkleinbort