lance icon indicating copy to clipboard operation
lance copied to clipboard

Could not make proto path relative

Open hemanth94 opened this issue 1 year ago • 4 comments

I'm running into this error with Lance-file build, while running cargo build for this project. I'm using Protoc 25.2 (latest). Am i missing something? Can someone please help me resolve this? Thanks in advance.

Could not make proto path relative

Screenshot 2024-01-22 135640

hemanth94 avatar Jan 22 '24 08:01 hemanth94

Hi @hemanth94. I'm not able to reproduce.

It seems like other users on Windows had success by re-installing Rust: https://github.com/hyperium/tonic/issues/821#issuecomment-957126990

Perhaps there is something wrong with your installation?

wjones127 avatar Jan 24 '24 17:01 wjones127

I tried reinstalling my rust, but the error repeats. I was thinking may be its the issue of Protoc Version.

Thanks.

hemanth94 avatar Jan 24 '24 19:01 hemanth94

@hemanth94, you might have figured it out by now, but I think you got this error because symlinks weren't created when you cloned the repo.

You can confirm by checking one of the 'protos' links:

➜ lance-table git:(main) Get-Item .\protos

    Directory: C:\Users\me\repos\lance\rust\lance-table

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---          2024-06-25    11:36             13 protos

If you clone with symlinks enabled, git clone -c core.symlinks=true https://github.com/lancedb/lance, you should see this instead:

➜ lance-table git:(main) Get-Item .\protos

    Directory: C:\Users\me\repos\lance\rust\lance-table

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
l----          2024-06-25    11:40                protos -> ..\..\protos\

(Note that you'll either need to turn developer mode on, or run that clone as an administrator. You can also enable symlinks for all future clones. https://stackoverflow.com/a/59761201)

NickDarvey avatar Jun 25 '24 01:06 NickDarvey

(I think this issue can be closed.)

NickDarvey avatar Jun 25 '24 01:06 NickDarvey

Hi, @NickDarvey I encountered the same issue on my Mac (M3 Pro), and was able to resolve it by following your suggestion — adding core.symlinks=true and doing clone again. Thank you very much for the help!

This problem can be quite unfriendly for new developers. Would it be possible to add a note in the documentation to warn or guide them?

codenohup avatar Jun 18 '25 15:06 codenohup