Make numpy optional pylance dependency

Open wjones127 opened this issue 2 years ago • 2 comments

I don't think it's required, and it adds ~15MB.

Sep 05 '23 15:09 wjones127

Hello @wjones127, I would like to take this issue. Thank you.

Sep 06 '23 07:09 rishabhRsinghvi

for anyone who may have come across this issue wondering why numpy is locked to <2.0, i want to add a comment to make a cross-reference back to the PR that created the lock:

https://github.com/lancedb/lance/pull/2637

furthermore, it seems that pyarrow themselves are working with the idea of making numpy dependency optional:

https://github.com/apache/arrow/pull/41904
https://github.com/apache/arrow/issues/25118

since the pyarrow PR was only merged last week, i'd expect this to be a part of the upcoming pyarrow 18 release. once that is complete, perhaps making numpy dependency optional for pylance would be easier

Sep 13 '24 00:09 jameswu1991