odil issues

Errors in the DIMSE-N message classes.

1

There are a few errors or inconsistencies in the newly added classes. I should have taken the time to take a look at the Pull request and make comments there....

cguebert

Throw a SocketClosed exception when the socket is closed.

1

There is currently no way to distinguish between the socket being closed and any exception occurring during message processing. As a temporary measure, I propose to send a SocketClosed exception...

cguebert

Type of elements in a data set cannot be modified

5

The type of elements in data set, once added, cannot be modified: they must be deleted and re-added. See the comments in 19cb2a8

lamyj

Members initialization in AssociationParameters

5

There are currently 3 constructors for AssociationParameters, but not all initialize all the class members. We can factor using class member initializers. Also, calling default constructors for members is not...

cguebert

Multiple receiver can be opened on the same port

See https://github.com/lamyj/odil/commit/514c8b6bf1e0e761b00cd58ba0bf5691f5b1e63a#commitcomment-19480460 The availability of the port should be checked before calling async_accept.

lamyj

Endless loop when a socket is closed without release

3

If a socket is closed on the other end without first sending an association release, my server is locked in a loop of : Operation error: End of file TCP...

cguebert