Roland Lammel comments

Results 87 comments of


                                            Roland Lammel

Consider making each package its own go module

That would be awesome and would allow keeping it all together here with simpler versioning. Need to take a look and give it a try.

Make checklist plugin compatible to Redmine 4.0.4

This pull request might also resolve/help with issue #33

Make checklist plugin compatible to Redmine 4.0.4

The TravisCI build failures do not seem to be related to the changes at all. So the Travis setup should be fixed too.

Make checklist plugin compatible to Redmine 4.0.4

Yes, it is compatible with Redmine 4.1 too. Using it already. Merging would be nice.

support redmine 3.4?

We used this plugin with Redmine 3.4 for quite some. So I guess this issue can be closed with Redmine 4.0 being stable for quite some time now.

Bind formdata with array input.

Data binding was improved with Echo v4.2. Please check the docs for [request binding](https://echo.labstack.com/guide/binding) Please close if this is resolved for you @mytc

Apply Middleware to a path (group, route, etc.)

As aldas said you just need to pass the middleware as additional argument to the group function: ```go e := echo.New() e.GET("/self", userController.GetSelf) // Guard group /users with middleware.CheckPermissions userGroup...

Apply Middleware to a path (group, route, etc.)

@BubbaJoe I guess with the comments it should work for you. So please let us know and close if you get it working.

Empty string turns into "false" bool during binding

This does not sound wrong actually. A boolean is either true or false and you declare Activate as a `bool`. You should change it to string if you expected an...

Empty string turns into "false" bool during binding

I'm only a contributor not the owner of the function. The same handling to set a valid value for an empty string is done for int, uint, float. Which is...