laminas-validator icon indicating copy to clipboard operation
laminas-validator copied to clipboard

QA(fix): Move laminas/service-manager back to dev dependencies

Open michalbundyra opened this issue 2 years ago • 1 comments

Pretty unsure why it was moved from dev dependencies in #129, but it seems to be wrong.

Still suggest section states:

"laminas/laminas-servicemanager": "Laminas\ServiceManager component to allow using the ValidatorPluginManager and validator chains",

so it is optional dependency and we should not be forced to install it, when we do not need it.

Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

michalbundyra avatar Mar 04 '24 18:03 michalbundyra

ValidatorPluginManager needs it. We should move away from optional dependencies. Especially now that incompatible service manager release was done

Xerkus avatar Mar 04 '24 18:03 Xerkus

@michalbundyra I agree with @Xerkus here. ServiceManager is an important dependency here and we need to restrict the installable version to those that are compatible.

gsteel avatar Jul 31 '24 08:07 gsteel