laminas-validator icon indicating copy to clipboard operation
laminas-validator copied to clipboard
verified publisher icon laminas

allow use of TranslatorInterface as Translator

Open mimmi20 opened this issue 2 years ago • 2 comments

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This PR wants to allow the use of Laminas\I18n\Translator\TranslatorInterface if 'MvcTranslator' is not available. This is related to #194.

mimmi20 avatar Jan 13 '24 11:01 mimmi20

@mimmi20 Please note: Laminas\Validator\Translator\TranslatorInterface !== Laminas\I18n\Translator\TranslatorInterface

https://github.com/laminas/laminas-validator/blob/bbb318490d186821e9488dcbc24455e1578717bb/src/Translator/TranslatorInterface.php#L3-L14

vs.

https://github.com/laminas/laminas-i18n/blob/99c7f8a2e1b286db71bee80f39f78b7d3c53d5d1/src/Translator/TranslatorInterface.php#L3-L18

froschdesign avatar Jan 13 '24 11:01 froschdesign

@mimmi20 I have marked this pull request as a draft in order to find a good and suitable solution.

Thanks for help! 👍🏻

froschdesign avatar Jan 13 '24 13:01 froschdesign

@froschdesign I'll leave it to you to merge and release if you're happy

gsteel avatar May 21 '24 21:05 gsteel

@froschdesign Is this one good to go? LMK and I'll merge and release - then I can cut a 3.0.x branch in the hope that we can get SMv4 happening here soon 🤞

gsteel avatar Jun 06 '24 13:06 gsteel