laminas-session icon indicating copy to clipboard operation
laminas-session copied to clipboard

Remove laminas/service-manager dependency and factory stubs

Open marcelthole opened this issue 9 months ago • 2 comments

Q A
Documentation yes
BC Break yes

Description

Background: @froschdesign comment here: https://github.com/laminas/laminas-session/pull/126#issuecomment-2832425562

You are adding support for laminas-servicemanager with version 4 here. Do you see a change to remove the dependency on the service manager?

In this PR i removed the servicemanager dependency completly. The configuration for the Laminas-servicemanager usage is still there. The biggest change here is the removal of the ContainerAbstractServiceFactory. This change is also documented in the migration guide from v2 to v3

marcelthole avatar May 05 '25 14:05 marcelthole

I presume this library will be used in some sort of Mezzio setup, which anyway have the Service Manager 3 or 4 required. So SM will be there anyway in vendor folder, required or not by laminas-session .

So i think is useless to remove this SM dependency.

arhimede avatar May 06 '25 09:05 arhimede

I presume this library will be used in some sort of Mezzio setup, which anyway have the Service Manager 3 or 4 required.

Not mandatory because any PSR-11 container can be used.

froschdesign avatar May 06 '25 09:05 froschdesign