laminas-session icon indicating copy to clipboard operation
laminas-session copied to clipboard

Move laminas-validator to require dependencies and bump the version with all dependencies

Open marcelthole opened this issue 10 months ago • 2 comments

Q A
BC Break yes

Description

Moved laminas-validator to the require section and bumped directly the version to ^3.0. This required to update some more dependencies and fix issues in the factories afterward.

I tried to make this PR as small as possible and didn't added typehints for methods that doesn't require it yet.

Relates to #114

marcelthole avatar Apr 25 '25 11:04 marcelthole

@marcelthole You are adding support for laminas-servicemanager with version 4 here. Do you see a change to remove the dependency on the service manager?

froschdesign avatar Apr 26 '25 16:04 froschdesign

@froschdesign i guess it should be possible. The only real usage is the \Laminas\Session\Service\ContainerAbstractServiceFactory that could be removed.

Than we could document it in the Migration guide that the consumer must use something like this:

'MySessionContainer' => static fn (ContainerInterface $c): \Laminas\Session\Container => new \Laminas\Session\Container('MySessionContainerNamespace', $c->get(ManagerInterface::class));

But i guess it make sense to split this in a second PR? Than i would create a Issue and PR for that one 👍

marcelthole avatar Apr 27 '25 07:04 marcelthole

Ahh i see there is already a duplicate in #103

marcelthole avatar Apr 30 '25 10:04 marcelthole

this PR was implemented in #103

arhimede avatar May 02 '25 16:05 arhimede