laminas-session icon indicating copy to clipboard operation
laminas-session copied to clipboard

Update laminas dependencies

Open stanis-molnar opened this issue 1 year ago • 4 comments

This PR simply updates the laminas dependencies and adapts accordingly the use of the new major versions of laminas-servicemanager and laminas-validator.

I also removed the php annotations and added explicit return types to the modified classes.

This unfortunately breaks backwards compatibility and will require the release of a new major version of laminas-session.

stanis-molnar avatar Jan 22 '25 21:01 stanis-molnar

@stanis-molnar — I've fixed the Psalm issues that were reported and pushed back to your branch.

I missed the part where you indicated a new major would be needed. I'll check with the @laminas/technical-steering-committee to see how we clear the BC breaks, and verify everyone is okay with the new major.

weierophinney avatar Jan 23 '25 21:01 weierophinney

@stanis-molnar — I've fixed the Psalm issues that were reported and pushed back to your branch.

I missed the part where you indicated a new major would be needed. I'll check with the @laminas/technical-steering-committee to see how we clear the BC breaks, and verify everyone is okay with the new major.

@weierophinney Thanks very much for taking care of that! Please let me know if any further actions on my side are needed.

stanis-molnar avatar Jan 24 '25 08:01 stanis-molnar

@weierophinney we are about to do 2 different PRs':

  • one against V2 to mark all deprecated functions as deprecated and to have new V2 release with that
  • one for V3 in order to implement service manager v4 and remove all deprecated functions

Now with this PR we are confused if is the case or not to commit our PR's, since is a different approach :-) Not sure why you say "Since the v2 createService() method cannot be removed before v4" , not sure what is the roadmap for this library .

arhimede avatar Jan 24 '25 10:01 arhimede

@weierophinney we are about to do 2 different PRs':

  • one against V2 to mark all deprecated functions as deprecated and to have new V2 release with that
  • one for V3 in order to implement service manager v4 and remove all deprecated functions

Now with this PR we are confused if is the case or not to commit our PR's, since is a different approach :-) Not sure why you say "Since the v2 createService() method cannot be removed before v4" , not sure what is the roadmap for this library .

I wasn't aware you were working on one, @arhimede ; I reviewed this one initially as it looked like it might fit in the 2.23.0 milestone. When I wrote those commit messages, I'd forgotten that this was the v2 series; that should have read "before v3".

I'm fine with waiting for your PR; marking deprecations first and then doing removal for next major makes sense.

weierophinney avatar Jan 24 '25 14:01 weierophinney