laminas-migration icon indicating copy to clipboard operation
laminas-migration copied to clipboard

Published 20 hours ago • verified publisher icon laminas

Support for PHP 8.1

Open pixeldev opened this issue 2 years ago • 5 comments

I was wondering if this package will be available for PHP 8.1 soon, since I need it to update a Magento project which was upgraded from 2.3.2 to 2.4.4.

pixeldev avatar Jun 06 '22 19:06 pixeldev

Do you see any errors currently when running it under PHP 8.1? If so, can you provide error messages, please?

weierophinney avatar Jun 06 '22 19:06 weierophinney

AFAIK, composer.json doesn't allow for PHP 8.1 here yet: send a patch, ans CI will verify compatibility

Ocramius avatar Jun 06 '22 20:06 Ocramius

Ref https://github.com/laminas/laminas-migration/blob/d7f569db79fdfbb56191528229b1a89cab9f02e0/composer.json#L15

Ocramius avatar Jun 06 '22 20:06 Ocramius

I guess one of the main reasons for this is that we do rely on PHPCompatibility codechecker here which does not really support PHP 8.0+

It seems that when we migrated to the GHA, we dropped the check-compat composer script call anyways and thus we can also just remove it. Psalm should already ensure that we do not use functions which are only available in more recent PHP versions.

boesing avatar Jul 10 '22 14:07 boesing

We can probably drop it from CI overall

Ocramius avatar Jul 10 '22 14:07 Ocramius