laminas-inputfilter
laminas-inputfilter copied to clipboard
[bc\break] Remove deprecated and validators auto injections
- Remove AllowEmpty / ContinueIfEmpty deprecated on 2.4.8. Zend\Validator\NotEmpty should be added to the ValidatorChain when expected.
- Remove UploadFile validator auto injection Zend\Validator\File\UploadFile should be added to the ValidatorChain when expected.
ToDo:
- [x] review coverage drop when uncovered lines grow
Originally posted by @Maks3w at https://github.com/zendframework/zend-inputfilter/pull/83
Code coverage drop its for a difference between phpunit code coverage versions.
Originally posted by @Maks3w at https://github.com/zendframework/zend-inputfilter/pull/83#issuecomment-165884000
@Maks3w can you drop into the summary how users can emulate the behavior using validators? Most will likely see this issue, see that the functionality was removed, but not know how to accomplish the behavior on their own.
Which brings me to the next point: can you start a migration/changes document detailing the change in behavior, please?
Originally posted by @weierophinney at https://github.com/zendframework/zend-inputfilter/pull/83#issuecomment-168820724
@Maks3w Are you still working on this?
Originally posted by @DASPRiD at https://github.com/zendframework/zend-inputfilter/pull/83#issuecomment-217743425
I'm not sure if continue with this or rewrite the component. There is not urgency for to merge this
Originally posted by @Maks3w at https://github.com/zendframework/zend-inputfilter/pull/83#issuecomment-217747089
https://github.com/zendframework/zend-inputfilter/issues/9 this issue just took up a whole afternoon. I was neck deep in filter chain debugging when a colleague found the above issue and we were able to turn off the auto injection.