laminas-filter icon indicating copy to clipboard operation
laminas-filter copied to clipboard

Initial Service Manager v4 Support

Open gsteel opened this issue 10 months ago • 2 comments

Provides initial support for SMv4

There is still a fair bit of work to do where the FilterPluginManager is consumed by FilterChain + other filters. These will need to be refactored with the FilterPluginManager as a hard-dependency in the constructor, otherwise none of the aliases will work now they have been extracted to the config provider.

Closes #125

gsteel avatar Apr 03 '24 23:04 gsteel

I wonder if we should provide a CallableFilter with v4 so that we do not have this mixed stuff laying around. Just not 100% sure where and how to map callables to the CallableFilter but that would at least reduce complexity a little bit. Just some thought which came to my mind, nothing we have to do - just wanted to drop that here.

boesing avatar Apr 04 '24 08:04 boesing

I wonder if we should provide a CallableFilter with v4 so that we do not have this mixed stuff laying around. Just not 100% sure where and how to map callables to the CallableFilter but that would at least reduce complexity a little bit. Just some thought which came to my mind, nothing we have to do - just wanted to drop that here.

I was thinking the same thing. Probably worth exploring in a separate patch

gsteel avatar Apr 04 '24 09:04 gsteel

@boesing - I'd appreciate another review when you get a chance! Cheers.

gsteel avatar Jun 13 '24 10:06 gsteel

will do later, have to take a 4h train and thus need some stuff to do 😁

boesing avatar Jun 13 '24 10:06 boesing

TYVM @boesing 🙏

gsteel avatar Jun 13 '24 11:06 gsteel