laminas-escaper
laminas-escaper copied to clipboard
laminas
remove maglnet/composer-require-checker as it is now in CI
| Q | A |
|---|---|
| Documentation | no |
| Bugfix | no |
| BC Break | no |
| New Feature | no |
| RFC | no |
| QA | yes |
Description
This PR:
- Removes
maglnet/composer-require-checkeras a dependency as it is now run inlaminas/laminas-ci-matrix-action(closes https://github.com/laminas/laminas-escaper/pull/33) - Updates
phpunit/phpunitto the minimum installable version
Is it planned to get composer-require-checker installed by default in the ci-action container?
@gsteel Yeah I jumped the gun on this as I remember seeing that it creates the job in the CI matrix action, and assumed that the tooling was installed in there too. Then I looked at adding it and realised we're in the same position as using composer to check semver ranges, we need PHP in the node image.
This is ready to go once that is worked out however.
That's great news - getting it installed on older PHP versions is a pain. So once implemented, it'll run require-checker on 8.0 as opposed to the matrix default stable?
Ideally, I don't think it should matter as long as it can check the composer.json file, so always using the latest version sounds ideal to me. But that is something we would need to think about when it comes to adding it.
Do we have a blocker PR that we can reference? I still see it running vendor/bin/composer-require-checker here
No PR yet, I thought this work was already done after checking the matrix, I missed that it was calling it from vendor/..., so I've created an issue for it instead. https://github.com/laminas/laminas-ci-matrix-action/issues/131