laminas-ci-matrix-action icon indicating copy to clipboard operation
laminas-ci-matrix-action copied to clipboard

Add in `composer-require-checker` as a globally installed tool

Open internalsystemerror opened this issue 2 years ago • 5 comments

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

composer-require-checker is a useful tool for ensuring that composer.json contains all the necessary required packages. It is advised to be used as a standalone tool, or as globally installed, not as a development dependency.

Ideally this should be installed into this action as a PHP tool, however this is dependent on the resolution of https://github.com/laminas/laminas-ci-matrix-action/pull/119.

internalsystemerror avatar Sep 13 '22 15:09 internalsystemerror

we first should see that we merge the matrix container and CI container into one project so we have aligned releases. Then we can add the tool to the CI container while providing the job via the matrix container.

I would not expect that we need to run composer require --global for that. If we want to have this installed for every CI run, we can add it to /usr/local/bin and use it.

Not sure why we need anything from #119, can you elaborate?

boesing avatar Sep 14 '22 11:09 boesing

Because it's a PHP tool requiring PHP and the matrix runs in JS was my thinking, but I guess the JS just needs to set up a job to run like PHPUnit (which I assume is already running on PHP).

internalsystemerror avatar Sep 14 '22 12:09 internalsystemerror

imho the matrix does not run any checks. The matrix should generate checks and thus I dont see the point why we want to execute the require checker here

boesing avatar Sep 14 '22 16:09 boesing

Indeed, matrix stays as-is, it's just the repositories that get together first

Ocramius avatar Sep 14 '22 16:09 Ocramius

I don't think we do want to do that, I was stating why I (mistakenly) thought #119 would be a blocker, but you're right we can just add it as another check once it's added to the ci container (however its installed).

internalsystemerror avatar Sep 14 '22 16:09 internalsystemerror