Fix: prevent forbidden characters in captcha id and double use of captcha
Solves this bug: https://github.com/laminas/laminas-captcha/issues/13 and another one where attackers could just resend the last captcha over and over again, until the expiration period has passed. Thats not what i would expect a captcha class to allow
BREAKING CHANGE: prevents double sending of captchas - invalidates them after successful validation by regeneration of words
@mkrasselt1 First: Thank you for your time and this contribution! 👍
Your changes would also have to be tested accordingly. Could you add the tests?
I can an I will :) (never worked with tests bevore but I will figure it out :))
Your changes would also have to be tested accordingly. Could you add the tests?
added two tests, should cover both new functions (reuse and id-injection)
are my tests sufficient ?
Let's give it a try, thank you @mkrasselt1