laminas-cache icon indicating copy to clipboard operation
laminas-cache copied to clipboard

Add suppport for `psr/cache` v2 and v3

Open jguittard opened this issue 2 years ago • 10 comments

Q A
Documentation no
Bugfix no
BC Break not yet
New Feature yes

Description

This adds support for psr/cache v2 and v3.

jguittard avatar May 19 '22 21:05 jguittard

The update of psr/cache is still blocked by several packages. Please run the following commands to see why this change currently makes no sense:

  • composer why-not psr/cache 2.0
  • composer why-not psr/cache 3.0

If the packages listed in the output do support psr/cache v2 & v3, you will see that tests are failing due to the imcompatibility of the psr/cache implementation in this repository. Just bumping composer.json won't be enough.

boesing avatar May 19 '22 21:05 boesing

I've created a new release of laminas/laminas-cache-storage-adapter-test to allow dev-master of cache/integration-tests. That component did not receive any new release for over a year now but dev-master removed some dependencies which seem not to be required 🤷🏼‍♂️

With this being done, the fun part can begin because the CacheItemPoolDecorator has to become compatible for v2 and v3 without breaking compatibility to v1 to avoid a new major here.

boesing avatar May 20 '22 15:05 boesing

Update: Had to update some more dependencies to actually provide support for PHP 8.1 without ignoring platform requirements.

I think the current state of this branch is a good starting point to provide support for both psr/cache v2 & v3.

boesing avatar May 20 '22 15:05 boesing

Hi! What are we waiting on this?

mrVrAlex avatar Jul 05 '22 11:07 mrVrAlex

I think this is ready? WDYT, @boesing? Blockers/dependencies?

Ocramius avatar Jul 05 '22 11:07 Ocramius

Tests are failing. I just fixed this PR after the initial creation to show that the changes which were made are not enough to mark this component as "compatible with psr/cache v3".

So until the tests are not passing, we can not merge this.

boesing avatar Jul 05 '22 12:07 boesing

Totally missed that, sorry 🤦

Ocramius avatar Jul 05 '22 12:07 Ocramius

Currently working on project migration to php8.1 and I hope this soon will be merged into branch because got composer conflicts with "- symfony/cache[v6.0.0, ..., v6.1.3] require psr/cache ^2.0|^3.0 -> found psr/cache[2.0.0, 3.0.0]" and I need minimum symfony/cache: v6 - to support php8.1. For now just getting this code from "jguittard/laminas-cache" because it is no other way to get it running on php8.1 with symfony/cache.

rimvislt avatar Aug 24 '22 14:08 rimvislt

@rimvislt just beware that you are running on broken shells until the build is green.

You can also rebase + fix any failures here, if you want to help out.

Ocramius avatar Aug 24 '22 14:08 Ocramius

Fixed in pr https://github.com/laminas/laminas-cache/pull/216

rimvislt avatar Sep 01 '22 11:09 rimvislt

any updates on this?

Fahl-Design avatar Jul 03 '23 12:07 Fahl-Design

Hello, any updates on this? thanks

ayurenia-seedbox avatar Jul 10 '23 12:07 ayurenia-seedbox

Closing in favor of #275

boesing avatar Aug 27 '23 00:08 boesing