automatic-releases icon indicating copy to clipboard operation
automatic-releases copied to clipboard
verified publisher icon laminas

Known limitation: can only handle the first 100 issues/PRs in a release

Open asgrim opened this issue 5 years ago • 3 comments

Bug Report

Q A
Version(s) 1.0.0

Summary

This is a known limitation currently.

asgrim avatar Jul 10 '20 09:07 asgrim

Affected code:

https://github.com/laminas/automatic-releases/blob/ea0062141bd984f60e4364600570487cec91b0d2/src/Github/Api/GraphQL/Query/GetMilestoneFirst100IssuesAndPullRequests.php#L12

An alternative implementation that can use graphql pagination is needed here.

Ocramius avatar Jul 10 '20 09:07 Ocramius

Or, you know, you can write better software, so each release has fewer bugs or errors and hence few issues/PR

Slamdunk avatar Jul 10 '20 14:07 Slamdunk

Hahahahahaha :D

Well, as it stands, that implementation is non-total, which is a clear bug. Whether it affects you is secondary :+1:

Ocramius avatar Jul 10 '20 14:07 Ocramius