jupyter-vim-binding icon indicating copy to clipboard operation
jupyter-vim-binding copied to clipboard

Erroneous Ex commands (e.g., :asdf) breaks vim bindings

Open slundqui opened this issue 7 years ago • 2 comments

Summary

Typing an erroneous ex command breaks vim bindings.

Environment

  • [Ubuntu 16.04 64 bit] Operating system : (e.g. Ubuntu Gnome 15.04 64bit)
  • [Chrome 59.0.3071.115] Web browser : (e.g. Firefox 44.0.2)
  • [4.3.0] Version or revision of Jupyter Notebook : (e.g. 4.1 or 620fb29)
  • [ae048fd025c80618238ace589e453dee53553001] Revision of jupyter-vim-binding : (e.g. 5a057d6)

Behavior

Once you type an erroneous ex command, navigation between code cells no longer work until you click on a cell with the mouse. Even after clicking in a cell, navigating within a cell changes the notebook cell focus while staying in insert mode within the clicked cell.

Expected

Vim bindings should work after erroneous ex commands

Actual

Vim bindings break after erroneous ex commands

Step by step procedure

  1. Start local Jupyter Notebook by jupyter notebook
  2. Access http://localhost:8888/
  3. Make multiple cells (shift-esc, o, o, o)
  4. Focus into a cell in the middle (k, i)
  5. Enter erroneous ex command (:asdf)
  6. Attempt to navigate to other cells (j, k)

What you have done to solve the issue

Reproduced with another machine (also running ubuntu, chrome browser)

slundqui avatar Jul 19 '17 19:07 slundqui

So you mean it seems errneous ex command somehow reset the mappings completly, right? While the plugin does not provide ex commands well, that kind of behaviors are not really tested sorry.

Currently I can get enough time to investigate it so please be patient or send me a pr :+1:

lambdalisue avatar Jul 20 '17 04:07 lambdalisue

s/I can/I can't

lambdalisue avatar Jul 20 '17 04:07 lambdalisue