lambdaworks
lambdaworks copied to clipboard
lambdaclass
feat: Banderwagon implementation
Tried implementing the serealisation and deserealisation properties of Banderwagon which set it apart from Bandersnatch. However I am not really sure about the tests and ready to accept any advice about them.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.32%. Comparing base (
52042bf) to head (faed9f7).
Additional details and impacted files
@@ Coverage Diff @@
## main #843 +/- ##
=======================================
Coverage 72.32% 72.32%
=======================================
Files 147 147
Lines 33820 33820
=======================================
Hits 24459 24459
Misses 9361 9361
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Serialization doesn't need to be defined for the curve. You serialize the points of the curve, not the curve, and it's defined elsewhere. Also, add some tests with specifics points obtained from the scripts we use with sage and test the operations with that.
Serialization doesn't need to be defined for the curve. You serialize the points of the curve, not the curve, and it's defined elsewhere. Also, add some tests with specifics points obtained from the scripts we use with sage and test the operations with that.
So should I just remove the definitions for serialization and deserialization including their tests?
Serialization doesn't need to be defined for the curve. You serialize the points of the curve, not the curve, and it's defined elsewhere. Also, add some tests with specifics points obtained from the scripts we use with sage and test the operations with that.
Added the sage script as comments in the tests
