concrete icon indicating copy to clipboard operation
concrete copied to clipboard

[Codegen] Implement proper type resolver

Open edg-l opened this issue 1 year ago • 1 comments

Right now we resolve types by name in a simple way, it probably needs enhancing and be done in a non stringly way.

Related code:

https://github.com/lambdaclass/concrete/blob/771662e8343e246cfee4bcbd935fd1374d90c324/crates/concrete_codegen_mlir/src/codegen.rs#L53-L81

edg-l avatar Jan 11 '24 08:01 edg-l

The function has been renamed to compile_type and a type Enum is used instead of a string. I think we should close this issue as resolved. @igaray

https://github.com/lambdaclass/concrete/blob/848181b2b8c4411dfb460b76f0242afb262b5a1a/crates/concrete_codegen_mlir/src/codegen.rs#L1332-L1384

JulianGCalderon avatar May 07 '24 16:05 JulianGCalderon