concrete icon indicating copy to clipboard operation
concrete copied to clipboard

Refactor generics code to acomodate future trait generics

Open edg-l opened this issue 7 months ago • 3 comments
trafficstars

Mainly changes the symbol resultion structs to improve usability and account for traits, since multiple methods with the same name may exist and may only be distinct by the trait they are implemented in.

This makes the code cleaner and more readable.

edg-l avatar Apr 08 '25 11:04 edg-l

Benchmarking (Linux) factorial

Compiling factorial (factorial.con) Finished release in 33.440121ms Running 5000000 iterations Using input value: 20 Concrete Result = 2432902008176640000 Time taken : 97.32 ms Rust Result = 2432902008176640000 Time taken : 60.46 ms

Benchmarking (Linux) fib

Compiling fib (fib.con) Finished release in 26.401217ms Running 5000 iterations Using input value: 20 Concrete Result = 6765 Time taken : 136.70 ms Rust Result = 6765 Time taken : 85.66 ms

github-actions[bot] avatar Apr 08 '25 11:04 github-actions[bot]

Benchmarking (macOS) factorial

Compiling factorial (factorial.con) Finished release in 981.648959ms Running 5000000 iterations Using input value: 20 Concrete Result = 2432902008176640000 Time taken : 31.97 ms Rust Result = 2432902008176640000 Time taken : 25.20 ms

Benchmarking (macOS) fib

Compiling fib (fib.con) Finished release in 192.611166ms Running 5000 iterations Using input value: 20 Concrete Result = 6765 Time taken : 120.48 ms Rust Result = 6765 Time taken : 115.29 ms

github-actions[bot] avatar Apr 08 '25 11:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 84.31373% with 48 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (4802a28) to head (b0d4e8d).

Files with missing lines Patch % Lines
src/ir/lowering/adts.rs 64.28% 20 Missing :warning:
src/ir/lowering/mod.rs 86.88% 8 Missing :warning:
src/ir/lowering/functions.rs 93.57% 7 Missing :warning:
src/ir/lowering/lower.rs 77.41% 7 Missing :warning:
src/driver/mod.rs 0.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   56.29%   59.18%   +2.89%     
==========================================
  Files          25       26       +1     
  Lines        5516     5892     +376     
==========================================
+ Hits         3105     3487     +382     
+ Misses       2411     2405       -6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 08 '25 12:04 codecov-commenter