cairo_native icon indicating copy to clipboard operation
cairo_native copied to clipboard

Remove manual type layouts.

Open azteca1998 opened this issue 1 year ago • 3 comments

Checklist

  • [ ] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.

azteca1998 avatar May 07 '24 10:05 azteca1998

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.282 ± 0.048 11.199 11.350 23.47 ± 0.10
cairo-native (embedded AOT) 1.514 ± 0.012 1.497 1.537 3.15 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 1.604 ± 0.009 1.593 1.621 3.34 ± 0.02
cairo-native (standalone AOT) 0.653 ± 0.001 0.650 0.655 1.36 ± 0.00
cairo-native (standalone AOT with -march=native) 0.481 ± 0.001 0.480 0.482 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.624 ± 0.083 10.556 10.758 1306.66 ± 18.40
cairo-native (embedded AOT) 1.094 ± 0.006 1.087 1.101 134.54 ± 1.72
cairo-native (embedded JIT using LLVM's ORC Engine) 1.109 ± 0.007 1.099 1.124 136.41 ± 1.82
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.009 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.885 ± 0.007 1.871 1.900 28.52 ± 0.14
cairo-native (embedded AOT) 1.242 ± 0.007 1.228 1.248 18.79 ± 0.11
cairo-native (embedded JIT using LLVM's ORC Engine) 1.422 ± 0.016 1.401 1.454 21.52 ± 0.25
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.108 1.62 ± 0.01
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.067 1.00

github-actions[bot] avatar May 09 '24 13:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 90.32717% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 91.32%. Comparing base (511faf7) to head (e6120ea). Report is 1 commits behind head on main.

Files Patch % Lines
src/values.rs 92.98% 24 Missing :warning:
src/executor.rs 87.66% 19 Missing :warning:
src/bin/cairo-native-run.rs 0.00% 12 Missing :warning:
src/bin/cairo-native-test.rs 50.00% 6 Missing :warning:
src/libfuncs/function_call.rs 45.45% 6 Missing :warning:
src/cache/aot.rs 85.71% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
- Coverage   91.38%   91.32%   -0.06%     
==========================================
  Files         109      109              
  Lines       35889    36234     +345     
==========================================
+ Hits        32797    33092     +295     
- Misses       3092     3142      +50     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 16 '24 09:05 codecov-commenter

✅ Code is now correctly formatted.

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]