cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

cairo1-run: honor relocate_mem and trace_enabled when relocating

Open sashass1315 opened this issue 2 months ago • 3 comments

  • Fix cairo1-run to use Cairo1RunConfig.relocate_mem and trace_enabled in runner.relocate(...) instead of unconditionally relocating both memory and trace.
  • This change brings Cairo1-run behavior in line with the Cairo 0.x runner, matches CLI expectations (trace/memory requested ⇒ relocate), and avoids unnecessary relocation work.

sashass1315 avatar Oct 23 '25 18:10 sashass1315

Hi @sashass1315, thanks for the contribution! Left you a small comment. Also, format seems to be failing.

JulianGCalderon avatar Oct 24 '25 19:10 JulianGCalderon

Hi @sashass1315! Any news on this PR?

gabrielbosio avatar Dec 02 '25 15:12 gabrielbosio

Hi @sashass1315! Any news on this PR?

Hi! Updated PR! thank you for review

sashass1315 avatar Dec 02 '25 21:12 sashass1315