lambda icon indicating copy to clipboard operation
lambda copied to clipboard

(Global but Baritone-dependent) Incompatibility with @Overwrite mixin mods such as Liquidbounce

Open Alluseri opened this issue 2 years ago • 4 comments

What mod? Liquidbounce(both legacy b2 and ported)

Logs Sample mixin error: https://pastebin.com/MxdS8YDq Semi-fixed crash: https://pastebin.com/FgYTwTRt Full logs and logs for other mixin errors upon request(I don't see a reason to provide them right away since these are the only relevant pieces)

Additional context @Overwriteing mixins cause SOME @At(value="FIELD") and @At(value="INVOKE") mixins of Baritone to break. Affected mixins: MixinEntityLivingBase.overrideYaw, MixinEntityPlayerSP.isAllowFlying, MixinEntityPlayerSP.isKeyDown After removing those mixins(using Recaf, don't have Gradle to recompile from source + overkill), the game launches but crashes soon(see log №2). Optional(unrelated to the absolute fix): make priority 999 or lower to respect overwritten methods(otherwise hooks can potentially be overwritten out). Decided not to post this in Baritone issues because it appears that they've dropped 1.12.2 support, correct me if I'm wrong.

CORRECTION: The standalone version of Baritone works just fine when fixed using the same method, no crashes.

Alluseri avatar Jul 08 '22 04:07 Alluseri

1.12.2 is the main branch of baritone.

0-x-2-2 avatar Jul 19 '22 21:07 0-x-2-2

This does not crash with standalone baritone because of mixin 0.8.x behavior change, this will silently fail on old versions of mixins such as what is distributed with baritone standalone but the real problem is with the people using overwrite, and that causes major issues because of mixin design flaws.

0-x-2-2 avatar Jul 19 '22 21:07 0-x-2-2

Liquidbounce on its way to overwrite the entire entity move method to add 5 lines

Doogie13 avatar Jul 20 '22 09:07 Doogie13

Liquidbounce on its way to overwrite the entire entity move method to add 5 lines

Yeah that made me laugh hard as fuck, sadly I don't know shit about Mixins so I have no idea how to rework it

Alluseri avatar Jul 29 '22 09:07 Alluseri

Heads up: I fixed Lambda to work with Liquidbounce and now it works.

Alluseri avatar May 05 '23 12:05 Alluseri