docker-lambda icon indicating copy to clipboard operation
docker-lambda copied to clipboard
verified publisher icon lambci

"Examples" link in the README is broken when viewed from hub.docker.com

Open jcoyne opened this issue 7 years ago • 3 comments

See here: https://hub.docker.com/r/lambci/lambda/

jcoyne avatar Jun 19 '18 12:06 jcoyne

fwiw, this is the case with almost every project README that has links. Docker Hub takes the README verbatim but doesn’t rewrite the links. Whether it should or not is another question... but I think you should expect that some README stuff will be broken on external services, with any project :)

tdmalone avatar Jun 19 '18 20:06 tdmalone

@tdmalone if you made it an absolute path, that would fix the problem, right?

jcoyne avatar Jun 19 '18 20:06 jcoyne

Yes it would, but then it would link to the wrong file in forks.

I guess it depends if you want it to work more on GitHub... or external services. I tend to think it should link relatively, so that the repo name isn't hardcoded, and the service displaying the file should work out how to handle that. But that's just my opinion and this isn't my repo :P

tdmalone avatar Jun 20 '18 07:06 tdmalone