Eduardo Salinas
Eduardo Salinas
Overlap with c# skip list: **258**,// crash **237**,, // native json parsing **195**,, //--onethread is a shell option, not available via library **239**, **240**, **241**, **242**, **243**, **244**, **245**, **246**,...
Whoops, did a click by mistake so ignore all those operations.
Reduction stacks exercised by RunTests: ``` gd->scorer, 36 gd->scorer->csoaa->search_task, 19 gd->scorer->csoaa_ldf->cb_adf->cb_explore_adf_greedy->cb_sample->shared_feature_merger->ccb_explore_adf, 12 ftrl->scorer, 10 cbzo, 10 gd->scorer->csoaa_ldf->cb_adf->shared_feature_merger, 9 gd->scorer->csoaa_ldf->cb_adf->cb_explore_adf_cover->shared_feature_merger, 8 gd->scorer->csoaa_ldf->cb_adf->cb_explore_adf_greedy->shared_feature_merger->warm_cb, 7 gd->scorer->oaa, 6 gd->scorer->csoaa->cb->cb_explore->cbify, 6 gd->scorer->csoaa_ldf->cb_adf->cb_explore_adf_greedy->shared_feature_merger, 6 gd->scorer->csoaa_ldf->shared_feature_merger, 5...
Seems to be some mismatch between float operations in different environments. This test is passing on our windows build CI. See https://github.com/VowpalWabbit/vowpal_wabbit/runs/6968381651?check_suite_focus=true Is this being tested on some new MSVC...
The perf test that would've catch this might be interesting to merge before this PR and then see the improvement get registered on the ci to validate this PR.
Previous PR (closed bc incomplete): https://github.com/VowpalWabbit/vowpal_wabbit/pull/3031
It is also a good idea to refer to the scripts that build VW on CI. script: https://github.com/VowpalWabbit/vowpal_wabbit/blob/master/.scripts/linux/build-minimal.sh on top of this image with the depedencies: https://github.com/VowpalWabbit/docker-images/blob/master/vowpal_wabbit/ubuntu1604-build.Dockerfile
closing bc references are made in other prs
Please re-open if you are still having issues.