github-changes icon indicating copy to clipboard operation
github-changes copied to clipboard
verified publisher icon lalitkapoor

Selective add

Open pfrazee opened this issue 11 years ago • 3 comments

Especially useful going off of #5, if there could be an "interactive add" mode to select Y/n for each commit/PR, that'd be pretty cool.

Right now I have to manually remove the extra items. OH THE HUMANITY. :crying_cat_face:

pfrazee avatar Feb 23 '14 18:02 pfrazee

@pfraze Good idea! I'll look into it after I get #5 in.

Can you tell me more about the items you are removing? Are they things like 'fixed typo', 'added comments', etc?

I'm interested in making this tool more useful and I have some questions that I'd love to get your thoughts on:

  • Can you describe your workflow with git (do you follow anything like git-flow, github-flow, etc)?
  • Do you use any commit message conventions (or would you consider adopting one)? E.g:
  • Do you squash your commits to maintain a clean history?
  • Do you prefer your changelog to be generated based on pull requests or commits (see examples in README.md if I'm not making myself clear)?
  • Do you want to hide commits coming in from a merge? - E.g. in the git log output below would you like to ignore the following: 9a92c0a, 780508f, f87ac86, 3f13e3c?
* 5fd36d8 - (tag: v0.0.3) 0.0.3 (18 hours ago) <Lalit Kapoor>
* 20749d9 - update for v0.0.3 (18 hours ago) <Lalit Kapoor>
*   3562aeb - Merge pull request #4 from lalitkapoor/4-consider-generating-changelog-based-on-commit-messages (18 hours ago) <Lalit Kap
|\
| * 9a92c0a - (origin/4-consider-generating-changelog-based-on-commit-messages, 4-consider-generating-changelog-based-on-commit-message
| * 780508f - update usage text for the --data arg in README (18 hours ago) <Lalit Kapoor>
| * f87ac86 - support for building change log via commit messages (18 hours ago) <Lalit Kapoor>
| * 3f13e3c - increase number of simultaneous http/https requests (18 hours ago) <Lalit Kapoor>
|/
*   407d29c - Merge branch 'master' of github.com:lalitkapoor/github-changes (2 days ago) <Lalit Kapoor>

Please let me know if you have any other questions or feedback!

Thanks!

lalitkapoor avatar Feb 24 '14 02:02 lalitkapoor

Can you tell me more about the items you are removing? Are they things like 'fixed typo', 'added comments', etc?

Yes, exactly. I think of the changelog as a higher-level overview compared to the commit log.

Regarding your questions:

  • Workflow: no standards, since I usually work alone. When in teams, I'll typically do master branch, dev branch, bug/feature branches, PR to merge.
  • Same story on commit message conventions-- I'd probably adopt the nodejs style. I like angular's, but that's tough to enforce if I don't run the team.
  • Nah. I plan to get into rebasing a bit more, but I currently let it all show as it happened for simplicity.
  • PRs vs. commits: the latter because of my current flow, but the former would make more sense if the git-flow model.
  • Hiding merge commits: no - I'd want them - but I am likely to not want the merge (3562aeb)

:+1:

pfrazee avatar Feb 24 '14 15:02 pfrazee

Thanks for that feedback @pfraze. I've made some changes to the tool and added a few additional options. I think you'll find the --no-merges to your liking, it'll hide 3562aeb for ya :)

I'm trying to remove reliance on the GitHub pull request API and deal directly with the commits (this part is still currently using the GitHub API). Anyway, as a result you'll see some deprecated functionality.

Please let me know if you have any thoughts about the new updates. Do you think the new flags all make sense? Is it easy enough to build a changelog you desire? Can't thank you enough for your feedback :)

lalitkapoor avatar Feb 25 '14 06:02 lalitkapoor