docx4js icon indicating copy to clipboard operation
docx4js copied to clipboard

An issue with parsing "NULL" relationship targets

Open max-rudnev opened this issue 2 years ago • 1 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/docx4js/lib/openxml/part.js b/node_modules/docx4js/lib/openxml/part.js
index c041ae5..a0d29d9 100644
--- a/node_modules/docx4js/lib/openxml/part.js
+++ b/node_modules/docx4js/lib/openxml/part.js
@@ -91,6 +91,7 @@ var Part = function () {
 		value: function getRel(id) {
 			var rel = this.rels("Relationship[Id=\"" + id + "\"]");
 			var target = rel.attr("Target");
+			if (target === 'NULL') return;
 			if (rel.attr("TargetMode") === 'External') return { url: target };
 
 			switch (rel.attr("Type").split("/").pop()) {
diff --git a/node_modules/docx4js/src/openxml/part.js b/node_modules/docx4js/src/openxml/part.js
index 1a1d690..a37a67d 100644
--- a/node_modules/docx4js/src/openxml/part.js
+++ b/node_modules/docx4js/src/openxml/part.js
@@ -63,6 +63,8 @@ export default class Part{
 	getRel(id){
 		var rel=this.rels(`Relationship[Id="${id}"]`)
 		var target=rel.attr("Target")
+		if(target==='NULL')
+			return;
 		if(rel.attr("TargetMode")==='External')
 			return {url:target}
 

This issue body was partially generated by patch-package.

max-rudnev avatar Sep 19 '22 14:09 max-rudnev