memcode icon indicating copy to clipboard operation
memcode copied to clipboard

We shouldn't refresh notifications on every page + fix localStorage

Open lakesare opened this issue 4 years ago • 1 comments

  1. Notifications should be renewed without setting { status: 'request' } on subsequent api calls.

  2. There shouldn't be a residual '1 notification is unread' when we:

  • have one notification
  • mark it as read
  • switch to another page, and see one notification as unread for a few seconds.

This happens because we don't update value in our localStorage whenever amount of unread notifications changes.

lakesare avatar Mar 28 '20 22:03 lakesare

Let's put <Notifications/> state into redux instead of keeping it in the component.

lakesare avatar Mar 29 '20 16:03 lakesare