memcode icon indicating copy to clipboard operation
memcode copied to clipboard

Korean text disappears after I enter the correct answer in cloze deletion cards

Open iopq opened this issue 1 year ago • 11 comments

It's actually not there, if I hit enter it marks me wrong

if I input it again it works, so I have to type the answer twice

iopq avatar Aug 11 '22 00:08 iopq

Do you have this issue too https://github.com/lakesare/memcode/issues/25?

lakesare avatar Aug 11 '22 04:08 lakesare

no, they just all disappear after I enter the last block, and only if it's the correct answer

edit: to be clear, when I do this in the same deck with an English cloze deletion card I got normal behavior

iopq avatar Aug 11 '22 16:08 iopq

In the console, I get both given is wanted and given isnt equal to wanted at the same time

iopq avatar Aug 12 '22 02:08 iopq

Aha. Could you please give me a link to one of your courses with this issue?

lakesare avatar Aug 12 '22 03:08 lakesare

https://www.memcode.com/courses/7296

iopq avatar Aug 12 '22 23:08 iopq

If you paste the answer, like just 연락처 into the of the cards it works fine. It's an issue because of how korean syllable blocks are constructed on the fly, and might be in particular a browser/platform issue

iopq avatar Aug 19 '22 04:08 iopq

https://photos.app.goo.gl/AonbhAWwyhT7v5YTA

Recorded using Android with Gboard keyboard

iopq avatar Sep 05 '22 09:09 iopq

Thank you, could reproduce this! I'll try to fix it today.

lakesare avatar Sep 05 '22 20:09 lakesare

Just deployed the possible solution. Please press CMD+SHIFT+R to make sure you get the latest version of code.

Try to:

  1. type in the answer as you usually do in Korean, and
  2. push the right arrow on your keyboard.

Please tell me if this works for you.

lakesare avatar Sep 05 '22 21:09 lakesare

I'm currently using my phone to review, but pressing show answer did the trick! Thanks, fixed for me

iopq avatar Sep 07 '22 17:09 iopq

There's a small bug in the fix:

If the correct word is ABC and I type ABCD it will reset the text field

Example: I changed some of the words to omit the grammatical endings, so the correct answer is shorter

if for the card that has the answer 끄 I write 끄다 it will erase my answer before I can delete the extra jamo. So basically when you exceed the correct answer it will erase it, apparently because it registered the answer as correct already and breaks when you just add random stuff at the end (of course it doesn't know the previous state of the card, so even if you write 끄아 it will mess up too)

iopq avatar Sep 18 '22 14:09 iopq

🤔 The current solution also makes the review of english words behave unusual on mobile. I'll see what I can do.

lakesare avatar Oct 02 '22 17:10 lakesare

I deployed the new solution for Korean inputs. Works on a desktop for me, please try it on your phone (make sure to hard reload the application).

lakesare avatar Oct 02 '22 18:10 lakesare

Works great on both now, thanks

iopq avatar Oct 08 '22 09:10 iopq