iredis icon indicating copy to clipboard operation
iredis copied to clipboard

I hope you can upgrade the iredis dependency click version to 8

Open ponponon opened this issue 2 years ago • 5 comments

But when I tried to install iredis, I found a conflict between flask and the version of click on which iredis depends

pip install iredis

error info 👇

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
flask 2.1.2 requires click>=8.0, but you have click 7.1.2 which is incompatible.

flask version info 👇

─➤  pip show flask    
Name: Flask
Version: 2.1.2
Summary: A simple framework for building complex web applications.
Home-page: https://palletsprojects.com/p/flask
Author: Armin Ronacher
Author-email: [email protected]
License: BSD-3-Clause
Location: /Users/ponponon/.local/share/virtualenvs/ideaboom-B0dr_aXc/lib/python3.10/site-packages
Requires: click, itsdangerous, Jinja2, Werkzeug
Required-by: 

ponponon avatar Jun 21 '22 09:06 ponponon

sure, why not.

laixintao avatar Jun 21 '22 11:06 laixintao

oh Click dropped Python3.6 support, since IRedis is still supporting 3.6, I think I need more time to upgrade.

https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

laixintao avatar Jun 21 '22 11:06 laixintao

oh Click 放弃了对 Python3.6 的支持,因为 IRedis 仍然支持 3.6,我想我需要更多的时间来升级。

https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

Yes, because click supports type annotations in 8.0, which requires python 3.7+

I think type annotations are a great effect that can help us improve the dynamic language refactoring crematorium

ponponon avatar Jun 24 '22 15:06 ponponon

Yes understand. I mean I may need more time to drop the support for Python3.6

laixintao avatar Jun 25 '22 04:06 laixintao

Hello, any news on this issue ? I'd also like to use click v8 along iredis

Lotram avatar Sep 29 '23 13:09 Lotram