Laird

Results 26 comments of Laird

By the way, @n-thumann, although I'm not an expert on Git etiquette, my understanding is that it's in general not a good idea to force-push changes to public repositories (including...

> Or maybe we can try this method: [Destroy666x@565262f](https://github.com/Destroy666x/mybb/commit/565262fd358228357f33cf4f7b4cd8f98282a246) That method has been implemented in PR #4707, which I think makes this PR redundant.

> I think @effone comment is on point, we shouldn't be explicit about the permission, instead we should trow an invalid user message so it is vague. I'm not sure...

This fix fails in three scenarios: 1. One or more spaces precede the opening "and" or "or" (it fails to remove the "and" or "or"). 2. The string starts with...

> > This fix fails in three scenarios: > > ``` > > 1. One or more spaces precede the opening "and" or "or" (it fails to remove the "and"...

> Doesn't change the fact it's better to implement now than forget down the road if the native function exits. Yeah, given that it's got a benefit (handling more cases...