goxc icon indicating copy to clipboard operation
goxc copied to clipboard

Add deb task configuration allowing the auto-inclusion of resources

Open pdf opened this issue 9 years ago • 9 comments

Allows the use of pre/post{inst,rm}, etc scripts. The resources-dir task setting should be set to the parent directory of a debian dir containing the resources.

pdf avatar Aug 16 '16 09:08 pdf

This is great. Thanks for taking the time to dig in and see what's up.

Please go ahead and merge. (see invite).

laher avatar Aug 20 '16 21:08 laher

There's actually a problem with the way debber handles this - resources appears to be the only way to get it to include debian contents in the control, however it doesn't exclude debian from data. Whilst doing the latter would be easy, I feel like these two mechanisms should really be decoupled - that would allow for a top-level debian directory, which feels more normal than having to nest it somewhere.

Happy for me to work up a debber PR to split debian handling out of resources?

pdf avatar Aug 21 '16 00:08 pdf

Yes, thank you. I can't honestly remember the details of how debber works right now (!) but it sounds like a sensible plan.

Please make a PR, and then if it introduces any backwards-incompatibility problems I am happy to just fork it into an 0.4. I never got the API to a point where it seemed 100% right, so I'm happy to take changes on board.

Really I'd love to spend some more time rounding out the debber project, but unfortunately/fortunately I just have a very busy life nowadays. ¯(ツ)

laher avatar Aug 21 '16 08:08 laher

Oh this is perfect! I was just wondering why my maintainer scripts didn't fire when installing the deb files.

When do you guys think this fix can be merged to master? Is there anything I can do to help?

stamp avatar Oct 25 '16 20:10 stamp

@stamp, I've not forgotten about this, I just haven't had time to get to it yet.

pdf avatar Oct 25 '16 20:10 pdf

Np

I actually found a workaround. I moved the debian folder to resources/debian instead and now it works fine. Just a warning that the control file is missing but it works great anyway.

stamp avatar Oct 25 '16 20:10 stamp

If you read my earlier comment (or install the resulting package) you'll discover the undesirable side-effect - a debian directory will also be deployed to the filesystem because it ends up in the data tarball, which is probably not what you want.

pdf avatar Oct 25 '16 21:10 pdf

I made a fix: https://github.com/debber/debber-v0.3/pull/3

What do you think? Seems to work fine in my environment at least.

stamp avatar Oct 25 '16 22:10 stamp

sorry, this is older than the sun itself. I merged @stamp's debber PR FWIW. I figure everyone's moved on with their lives since this was created. :shrug: many apologies.

laher avatar Oct 01 '20 10:10 laher