lagopus icon indicating copy to clipboard operation
lagopus copied to clipboard

Enable OF-compatible queue handling

Open eugene-che opened this issue 9 years ago • 4 comments

  • Remove the restriction on queue ids
    • now it is possible to create queues with the same id at different ports;
  • Fix qos scheduler initialization:
    • add a more rigorous checks for shaping parameters;
    • rollback to previos scheduler config on errors;
    • map queues to DPDK scheduler to enable PQ;
  • Enable queue scheduling for each transmitted packet;
  • Add support for queue_config and queue_stats openflow requests;
  • Change DPDK build options to enable qos scheduler statistics.

eugene-che avatar Apr 27 '16 09:04 eugene-che

Hi @eugene-che

Thank you for queue improvement pull request. Your pull request looks good but several modifies are required for merge.

  • Could you modify several single if conditional to be put on a separate line?
  • Could you fix a typo (eidt -> edit)?

The following make option is very useful for checking the syntax and make code more beautiful with our coding style.

$ make beautify

thanks!

ynkjm avatar May 09 '16 09:05 ynkjm

Hi @ynkjm

Thanks for the review! I have updated the patch to meet your suggestions.

eugene-che avatar May 10 '16 15:05 eugene-che

Hi @eugene-che

Thanks you for your modification. I will check it in our lab.

ynkjm avatar May 13 '16 04:05 ynkjm

Hi @eugene-che

We have checked your patch in our lab. We found some unit test errors. I'm try to investigate these unit test errors.

ynkjm avatar May 16 '16 09:05 ynkjm