lagopus
lagopus copied to clipboard
Enable OF-compatible queue handling
- Remove the restriction on queue ids
- now it is possible to create queues with the same id at different ports;
- Fix qos scheduler initialization:
- add a more rigorous checks for shaping parameters;
- rollback to previos scheduler config on errors;
- map queues to DPDK scheduler to enable PQ;
- Enable queue scheduling for each transmitted packet;
- Add support for queue_config and queue_stats openflow requests;
- Change DPDK build options to enable qos scheduler statistics.
Hi @eugene-che
Thank you for queue improvement pull request. Your pull request looks good but several modifies are required for merge.
- Could you modify several single if conditional to be put on a separate line?
- Could you fix a typo (eidt -> edit)?
The following make option is very useful for checking the syntax and make code more beautiful with our coding style.
$ make beautify
thanks!
Hi @ynkjm
Thanks for the review! I have updated the patch to meet your suggestions.
Hi @eugene-che
Thanks you for your modification. I will check it in our lab.
Hi @eugene-che
We have checked your patch in our lab. We found some unit test errors. I'm try to investigate these unit test errors.