online-auction-scala icon indicating copy to clipboard operation
online-auction-scala copied to clipboard

Search feature completion

Open ignasi35 opened this issue 6 years ago • 1 comments

online-auciton-scala's version of the Search service is not as complete as the java equivalent in online-auction-java. For starters: there's no UI.

As raised in https://github.com/lagom/online-auction-scala/pull/68, there was a runtime issue fixed in https://github.com/lagom/online-auction-scala/pull/72. But https://github.com/lagom/online-auction-scala/pull/72 exposed another runtime issue:

$ curl -d'{"keywords":"chair","maxPrice":10, "currency":"USD"}' -X POST -H "Content-Type: application/json" "http://localhost:9000/api/search?pageNo=1&pageSize=10"

returns:

{"name":"UndeserializableException","detail":"{\"error\":{\"root_cause\":[{\"type\":\"parsing_exception\",\"reason\":\"[itemStatus] query malformed, no start_object after query name\",\"line\":1,\"col\":63}],\"type\":\"parsing_exception\",\"reason\":\"[itemStatus] query malformed, no start_object after query name\",\"line\":1,\"col\":63},\"status\":400}"}

ignasi35 avatar Apr 03 '18 10:04 ignasi35

It looks like we have two tasks at-hand here:

  1. Build a UI for searching auction items
  2. Address runtime issue in SearchService.search (I've created https://github.com/lagom/online-auction-scala/issues/112 to discuss this separately).

When https://github.com/lagom/online-auction-scala/issues/112 is resolved, we should take a look at https://github.com/lagom/online-auction-scala/pull/113, which introduces a Search UI based on the Java implementation.

Let me know if you have any questions!

ryanhanks avatar Mar 23 '19 15:03 ryanhanks