pynsights icon indicating copy to clipboard operation
pynsights copied to clipboard

Runs too fast, counts only 1 call

Open pawamoy opened this issue 3 years ago • 3 comments

I tried the latest changes, and there's an issue in the HTML/JS file. The whole run finishes in less than a second, even when the recording has more than 40k calls. Moreover, the call counters show 1 everywhere. Only one dot is sent on every edge. If I click Start again, same thing, though counters are incremented to 2 (they should reset to 0).

I can send you gifs and/or my data files!

pawamoy avatar Nov 16 '21 11:11 pawamoy

Good find. I optimized the recording to save space and forgot to update the UI. Fixed it here https://github.com/laffra/pynsights/commit/f68c526dc692a62defd3629819f8f516190c1cfa#diff-28047d55b712f2c1aff7aee146b4a13094ee236ff84360971aa58130d79d689c .

On Tue, Nov 16, 2021 at 12:22 PM Timothée Mazzucotelli < @.***> wrote:

I tried the latest changes, and there's an issue in the HTML/JS file. The whole run finishes in less than a second, even when the recording has more than 40k calls. Moreover, the call counters show 1 everywhere. Only one dot is sent on every edge. If I click Start again, same thing, though counters are incremented to 2 (they should reset to 0).

I can send you gifs and/or my data files!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/laffra/pynsights/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4XAKDRPSQA2T7X6HVE2STUMI5G7ANCNFSM5IEAF33A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

laffra avatar Nov 16 '21 12:11 laffra

Perfect, thanks! Will try it out

pawamoy avatar Nov 16 '21 13:11 pawamoy

So, the counts are correctly displayed now, however it still runs very fast: only one dot per vertex/edge in under a second, counter going from 0 to total calls.

pawamoy avatar Nov 16 '21 21:11 pawamoy