ansible-role-proxmox icon indicating copy to clipboard operation
ansible-role-proxmox copied to clipboard

Published 20 hours ago • verified publisher icon lae

Fix host used to configure HA groups

Open btravouillon opened this issue 2 years ago • 4 comments

When the role is run with --limit nodes_without_first_node, the HA groups are not configured (tasks are skipped). Use _init_node instead of groups[pve_group][0] to run the tasks.

_init_node is any active node in an already initialized Proxmox cluster which is part of the run.

btravouillon avatar Feb 18 '23 18:02 btravouillon

Correct me if I'm wrong, but this looks like a possible QoL improvement throughout the entire role, actually, and not just for these tasks.

The tasks in main.yml that are run against the first cluster node probably could make use of this change. Do you think you can expand the scope of this to all tasks that reference groups[pve_group][0]?

lae avatar Feb 18 '23 18:02 lae

@btravouillon since it's been some time, am I okay to assume your +1 is to indicate that you'll update this PR with what I suggested sometime?

lae avatar Feb 21 '23 22:02 lae

Oh yes, sorry. I'm quite busy this week but I'll try to take a look at this asap.

btravouillon avatar Feb 21 '23 22:02 btravouillon

no problem, just checking. take your time.

lae avatar Feb 21 '23 22:02 lae

Looks like my vagrant setup is broken, but these changes seem trivial so I'll merge without testing.

lae avatar Mar 15 '24 14:03 lae