ansible-role-netbox icon indicating copy to clipboard operation
ansible-role-netbox copied to clipboard

Role needs to be updated to latest NetBox

Open lae opened this issue 3 years ago • 6 comments

Hey guys. I haven't managed to proactively keep this role in sync with upstream (living circumstances over the past year and a half haven't been very conducive to many activities), so I could use some help if anyone's willing to pitch in.

Basically, the major version release notes and all minor version update notes for NetBox need to be reviewed and then this role needs to be updated to support new features or use updated configurations, etc. Some changes that might affect earlier versions negatively may need to be version-gated, as well.

This should be done separately for the latest 2.10 and latest 2.11 releases. Refer to the following PRs for examples of how it's been done in the past.

  • https://github.com/lae/ansible-role-netbox/pull/27
  • https://github.com/lae/ansible-role-netbox/pull/40
  • https://github.com/lae/ansible-role-netbox/pull/61
  • https://github.com/lae/ansible-role-netbox/pull/67
  • https://github.com/lae/ansible-role-netbox/pull/87
  • https://github.com/lae/ansible-role-netbox/pull/115

Please feel free to open a PR like this to keep track of your work if you'd like to work on this. I'd greatly appreciate it. Whenever possible, I'll try to provide my own code reviews as well.

In the worst case that this isn't able to be completed sooner, I'll probably be able to focus more on this hopefully by the end of the year.

lae avatar Jul 07 '21 14:07 lae

I can confirm that role (as of now) works perfectly for 2.10 and 2.11 (I'm currently using netbox 2.11.11) But now 3.0.1 is present, so it may break

Dzordzu avatar Sep 06 '21 16:09 Dzordzu

I'm not too surprised that it works as-is for later versions, but if there were new features introduced they might need configuration support within the role.

lae avatar Sep 06 '21 21:09 lae

Hello,

I am interesting to help you on this topic to be able to install Netbox 3 with your role. Perhaps it's possible to create several issues with a tag "netbox_3.0" for example. It will be easy after to create MR for each issue.

What do you think ?

Regards,

smutel avatar Dec 16 '21 16:12 smutel

Just did an update from Netbox v2.11.11 to v3.1.9 by using the changes in PR #134 and #136 and didn't run into any issues.

TheMonkeyBrain avatar Mar 08 '22 09:03 TheMonkeyBrain

I did an upgrade from 2.10.10 to 3.1.11 using #141 and it went smoothly.

tyler-8 avatar Apr 20 '22 14:04 tyler-8

Guy may I suggest to add to the readme as prequisite to make this role work ? (for those who use ansible-core)

ansible-galaxy collection install community.postgresql   

MozeBaltyk avatar Feb 23 '24 10:02 MozeBaltyk