Louis-Alexandre Duchesneau

Ive reviewed the changes, all looks good. I will also run test on my end. To be honest, packed GSM never worked for me with gosmpp, even thou my SMSC...

LGTM (mostly) I opened a [comment/question](https://github.com/linxGnu/gosmpp/pull/136/files#r1482346899) for the code block added in Shortmessage.go

Hi, I did test and it did not work....but its not the library, its the SMSC, its currently configured for 8bit GSM. That said, I did test your code with...

Checks are failing because the test coverage is low. I'm working on increasing test coverage, especially for receivable.go and transmittable.go.

The last commit added the last feature for this PR, with all test completed. Again, this feature should not introduce any breaking changes or impact current user implementations. All previous...

Hi @linxGnu, please take your time. Please don't hesitate to add questions or comments to code and I will respond. Thanks

Ive pushed a first draft of the interface and its implementation: - still need to add context support - currently using settings to set WindowStore

For the last three days, Ive tried to implement bigcache as the default store. The main problem is the serialization of the data. When using bigcache, we loose the feature...

> @laduchesneau could you please fix the conflicts. > > After that, I think we can have a final review round. Since we expose the interface for custom cache, we...

Hi @linxGnu , Ive been using this branch in production for a couple of months, with 0 issues. Of course, there is no guarantee somebody else wont find a bug....