superagent icon indicating copy to clipboard operation
superagent copied to clipboard

[fix] .. in path gets collapsed after 9.0.2

Open vpzomtrrfrt opened this issue 1 year ago • 2 comments

Describe the bug

Node.js version: 20.15.1

OS version: Gentoo Linux rolling

Description: superagent started attempting to canonicalize URL paths in 9.0.2

Actual behavior

.. in paths gets interpreted by superagent, e.g. /api/v2/../error gets sent as /api/error.

Expected behavior

Paths should be sent as-is, or at least this should have waited for a major release

Code to reproduce

require("superagent").get("http://localhost:3000/api/v2/../error").then(console.log, console.error)

Checklist

  • [x] I have searched through GitHub issues for similar issues.
  • [ ] I have completely read through the README and documentation.
  • [ ] I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.

vpzomtrrfrt avatar Sep 06 '24 22:09 vpzomtrrfrt

Bisecting shows 7e20ced59db3f8289276ffef168145f9aec9ba23 as breaking this

vpzomtrrfrt avatar Sep 06 '24 22:09 vpzomtrrfrt

PR welcome

titanism avatar Sep 06 '24 22:09 titanism