superagent icon indicating copy to clipboard operation
superagent copied to clipboard

fix: agent cookie host assignment

Open robaca opened this issue 1 year ago • 2 comments

Checklist

  • [X] I have ensured my pull request is not behind the main or master branch of the original repository.
  • [X] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • [X] I have written a commit message that passes commitlint linting.
  • [X] I have ensured that my code changes pass linting tests.
  • [ ] I have ensured that my code changes pass unit tests.
    • [ ] multipart tests are green
  • [X] I have described my pull request and the reasons for code changes along with context if necessary in ticket 1807

robaca avatar Jul 03 '24 07:07 robaca

`` @ Uploading check-list-icon.png…

mohammed-mhmu avatar Sep 01 '24 23:09 mohammed-mhmu

What's preventing a merge here?

The multipart tests (which should not relate to my fix) are not working but as you can see here, they are not even causing a failing CI pipeline.

robaca avatar Sep 10 '24 10:09 robaca